diff options
| author | emmett1 <emmett1.2miligrams@protonmail.com> | 2024-05-24 12:22:12 +0800 |
|---|---|---|
| committer | emmett1 <emmett1.2miligrams@protonmail.com> | 2024-05-24 12:22:12 +0800 |
| commit | 46ca440e9d6cc606d9c3233021e32d24b25172cf (patch) | |
| tree | eeb573e47ac56498fbf74bda6d22fac47038ecab /repos/core/busybox/install-fix-chown.patch | |
| parent | 8c2e7bb570c11a51fdcecf7302af4058757d862c (diff) | |
| download | alicelinux-46ca440e9d6cc606d9c3233021e32d24b25172cf.tar.gz alicelinux-46ca440e9d6cc606d9c3233021e32d24b25172cf.zip | |
added repos
Diffstat (limited to 'repos/core/busybox/install-fix-chown.patch')
| -rw-r--r-- | repos/core/busybox/install-fix-chown.patch | 36 |
1 files changed, 36 insertions, 0 deletions
diff --git a/repos/core/busybox/install-fix-chown.patch b/repos/core/busybox/install-fix-chown.patch new file mode 100644 index 00000000..31ecd3c8 --- /dev/null +++ b/repos/core/busybox/install-fix-chown.patch @@ -0,0 +1,36 @@ +chown must precede chmod because on some systems, +chown clears the set[ug]id bits for non-superusers, +resulting in incorrect permissions. +diff --git a/coreutils/install.c b/coreutils/install.c +index 8270490..0256aeb 100644 +--- a/coreutils/install.c ++++ b/coreutils/install.c +@@ -244,6 +244,14 @@ int install_main(int argc, char **argv) + } + } + ++ /* Set the user and group id */ ++ if ((opts & (OPT_OWNER|OPT_GROUP)) ++ && lchown(dest, uid, gid) == -1 ++ ) { ++ bb_perror_msg("can't change %s of %s", "ownership", dest); ++ ret = EXIT_FAILURE; ++ } ++ + /* Set the file mode (always, not only with -m). + * GNU coreutils 6.10 is not affected by umask. */ + if (chmod(dest, mode) == -1) { +@@ -254,13 +262,6 @@ int install_main(int argc, char **argv) + if (use_default_selinux_context) + setdefaultfilecon(dest); + #endif +- /* Set the user and group id */ +- if ((opts & (OPT_OWNER|OPT_GROUP)) +- && lchown(dest, uid, gid) == -1 +- ) { +- bb_perror_msg("can't change %s of %s", "ownership", dest); +- ret = EXIT_FAILURE; +- } + next: + if (ENABLE_FEATURE_CLEAN_UP && isdir) + free(dest); |