diff options
| author | Woodpecker CI <emmett1.2miligrams@protonmail.com> | 2025-06-25 15:05:55 +0000 |
|---|---|---|
| committer | Woodpecker CI <emmett1.2miligrams@protonmail.com> | 2025-06-25 15:05:55 +0000 |
| commit | 9a348944d213706b16546ec8e2ab6caf0b596ad6 (patch) | |
| tree | 96317ac0f218e4f8540634b137b63bb07ac0642e /busybox/0034-adduser-remove-preconfigured-GECOS-full-name-field.patch | |
| parent | 7e73781cb2e573984e0b0afa4e689c83fe62fa04 (diff) | |
| download | alicelinux-9a348944d213706b16546ec8e2ab6caf0b596ad6.tar.gz alicelinux-9a348944d213706b16546ec8e2ab6caf0b596ad6.zip | |
Woodpecker CI e4bf8271be45598172db7947840ed98db83f3d0f [SKIP CI]
Diffstat (limited to 'busybox/0034-adduser-remove-preconfigured-GECOS-full-name-field.patch')
| -rw-r--r-- | busybox/0034-adduser-remove-preconfigured-GECOS-full-name-field.patch | 40 |
1 files changed, 40 insertions, 0 deletions
diff --git a/busybox/0034-adduser-remove-preconfigured-GECOS-full-name-field.patch b/busybox/0034-adduser-remove-preconfigured-GECOS-full-name-field.patch new file mode 100644 index 00000000..aeb47b83 --- /dev/null +++ b/busybox/0034-adduser-remove-preconfigured-GECOS-full-name-field.patch @@ -0,0 +1,40 @@ +Patch-Source: https://lists.busybox.net/pipermail/busybox/2024-November/091029.html +--- +From 77e364c66bf1208269a257bf23bcdb07ac50b5cd Mon Sep 17 00:00:00 2001 +From: fossdd <fossdd@pwned.life> +Date: Sat, 16 Nov 2024 22:21:12 +0100 +Subject: [PATCH] adduser: remove preconfigured GECOS full name field + +Pre-configuring "Linux User" as Full Name is confusing a lot of users +downstream.[1] For example, in geary e-mails were sent out as "Linux +User"[2] and I also saw a couple of git commits with this name. This name +does not bring any more improvements than just leaving this field +empty, and let applications most likely fallback to the username. + +Alternative would be to set the field to `&` (Capitalized username, +according to passwd(5)) or that we just set the GECOS field downstream. + +[1] https://gitlab.postmarketos.org/postmarketOS/pmbootstrap/-/issues/2214 +[2] https://gitlab.gnome.org/GNOME/geary/-/issues/1486 + +Signed-off-by: fossdd <fossdd@pwned.life> +--- + loginutils/adduser.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/loginutils/adduser.c b/loginutils/adduser.c +index d3c795afa..bfab05203 100644 +--- a/loginutils/adduser.c ++++ b/loginutils/adduser.c +@@ -196,7 +196,7 @@ int adduser_main(int argc UNUSED_PARAM, char **argv) + bb_simple_error_msg_and_die(bb_msg_perm_denied_are_you_root); + } + +- pw.pw_gecos = (char *)"Linux User,,,"; ++ pw.pw_gecos = (char *)""; + /* We assume that newly created users "inherit" root's shell setting */ + pw.pw_shell = xstrdup(get_shell_name()); /* might come from getpwnam(), need to make a copy */ + pw.pw_dir = NULL; +-- +2.47.1 + |